Add module in SentryStackFrame #2931
Open
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2931 +/- ##
=======================================
Coverage 87.65% 87.66%
=======================================
Files 272 272
Lines 9048 9052 +4
=======================================
+ Hits 7931 7935 +4
Misses 1117 1117 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The current failures seem to be due to the CI setup. The integration test complains about a missing auth token, I suppose that's due to me being an outside contributor, and the non-integration test failure is due to 429 too many request flake. |
ueman
requested review from
krystofwoldrich,
stefanosiano,
buenaflor and
denrase
as code owners
|
@buenaflor Is there anything left to do here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
For package frames, the module gets now reported. This allows users to use the
stack.modulefilter in the Sentry search.💡 Motivation and Context
#2929
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps