Skip to content

Add module in SentryStackFrame #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 17, 2025
Merged

Add module in SentryStackFrame #2931

merged 15 commits into from
Jun 17, 2025

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented May 12, 2025

📜 Description

For package frames, the module gets now reported. This allows users to use the stack.module filter in the Sentry search.

💡 Motivation and Context

#2929

💚 How did you test it?

  • New tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (95280e5) to head (f8721e5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2931   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files         278      278           
  Lines        9176     9180    +4     
=======================================
+ Hits         8041     8045    +4     
  Misses       1135     1135           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ueman added 4 commits May 12, 2025 14:43
@ueman
Copy link
Collaborator Author

ueman commented May 13, 2025

The current failures seem to be due to the CI setup. The integration test complains about a missing auth token, I suppose that's due to me being an outside contributor, and the non-integration test failure is due to 429 too many request flake.

@ueman ueman marked this pull request as ready for review May 13, 2025 05:08
@ueman
Copy link
Collaborator Author

ueman commented May 19, 2025

@buenaflor Is there anything left to do here?

ueman added 2 commits June 16, 2025 15:52
@ueman
Copy link
Collaborator Author

ueman commented Jun 17, 2025

@buenaflor Friendly ping to get this merged :)

@buenaflor
Copy link
Contributor

Last I checked (a month ago) it did not break grouping but unfortunately now it does so we can't merge it as it is currently.

I'm not sure if something changed in the backend grouping behaviour.

We can make this opt-in but I'm convinced no one will ever enable it if it is

@ueman
Copy link
Collaborator Author

ueman commented Jun 17, 2025

So what's the way forward here? This functionality is super valuable for us, and I don't see how to make this possible without any changes to the SDK itself

@buenaflor
Copy link
Contributor

If you really need it then I'd put it behind a flag (opt-in), maybe includeModuleInStackTrace and comment that it might break grouping when enabled.

buenaflor and others added 6 commits June 17, 2025 14:16
…dule
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 👍

will merge once tests pass, e2e tests I guess fail because of permissions

@buenaflor buenaflor merged commit 40e7bc6 into getsentry:main Jun 17, 2025
143 of 146 checks passed
@ueman ueman deleted the add-module branch June 17, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants